Skip to content

date: support european dates - #13818

Closed
MuntasirSZN wants to merge 3 commits into
uutils:mainfrom
MuntasirSZN:date-pl
Closed

date: support european dates#13818
MuntasirSZN wants to merge 3 commits into
uutils:mainfrom
MuntasirSZN:date-pl

Conversation

@MuntasirSZN

@MuntasirSZN MuntasirSZN commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

date accepts DAY.MONTH[.YEAR] dates (yearless forms use the current
year) and years beyond 9999 with any format. uutils/coreutils rejected both,
failing parts of tests/date/date.pl.

Rewrite european dates to ISO before parsing; accept extended years for
all output formats. Adds unit and integration tests.

tests/date/date.pl gnu test now passes.

Signed-off-by: MuntasirSZN muntasir.joypurhat@gmail.com

@codspeed

codspeed Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 12 untouched benchmarks
⏩ 444 skipped benchmarks1

Comparing MuntasirSZN:date-pl (52d98f1) with main (8b27533)

Open in CodSpeed

Footnotes

  1. 444 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

@collinfunk

collinfunk commented Aug 9, 2026

Copy link
Copy Markdown

These tests are copied from GNU coreutils and should be licensed as such.

@MuntasirSZN

MuntasirSZN commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

These tests are copied from GNU coreutils and should be licensed as such.

Ok I gave attribution

@xtqqczze

xtqqczze commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

These tests are copied from GNU coreutils and should be licensed as such.

As per CONTRIBUTING.md, we cannot accept any changes based on the GNU source code. I recommend closing this PR and starting again from scratch.

@sylvestre

sylvestre commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

yeah, you need to rewrite the tests

@MuntasirSZN

MuntasirSZN commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

yeah, you need to rewrite the tests

Ok doing it....

@github-actions

github-actions Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 153.09 MB (+912 KB, +0.59%)

Significant per-binary changes:
  expr     2.76 MB ->    3.65 MB  (+908 KB, +32.11%)

@MuntasirSZN
MuntasirSZN force-pushed the date-pl branch 2 times, most recently from c918fea to e991362 Compare August 9, 2026 14:49
@MuntasirSZN

MuntasirSZN commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre @collinfunk @xtqqczze Sorry for ping, can you guys check now?

@xtqqczze

xtqqczze commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

@MuntasirSZN Could you please confirm that no code in this PR has been derived from GNU coreutils or any other GPL-licensed source, including small snippets, helper structures, test fixtures, or comments?

If you used an AI assistant during development, please also verify its output carefully, as AI-generated code may reproduce material from GPL-licensed sources, potentially without making the provenance apparent.

@MuntasirSZN

MuntasirSZN commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@MuntasirSZN Could you please confirm that no code in this PR has been derived from GNU coreutils or any other GPL-licensed source, including small snippets, helper structures, test fixtures, or comments?

If you used an AI assistant during development, please also verify its output carefully, as AI-generated code may reproduce material from GPL-licensed sources, potentially without making the provenance apparent.

No, @xtqqczze. I verified myself.

@MuntasirSZN
MuntasirSZN force-pushed the date-pl branch 2 times, most recently from 7362f2a to 5c25094 Compare August 11, 2026 03:19
@MuntasirSZN

MuntasirSZN commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre @cakebaker review pls? Sorry for ping.

@MuntasirSZN

MuntasirSZN commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre @cakebaker is there anything else that is needed?

Copilot AI lite review requested due to automatic review settings August 20, 2026 02:34
Copilot AI reviewed Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MuntasirSZN

MuntasirSZN commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@xtqqczze @sylvestre @cakebaker This is another ping...

Copilot AI review requested due to automatic review settings August 22, 2026 11:48
Copilot AI reviewed Aug 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 23, 2026 05:17
Copilot AI reviewed Aug 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 22, 2026 09:36
Copilot AI reviewed Sep 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sylvestre
sylvestre reviewed Sep 22, 2026
View reviewed changes
Comment thread src/uu/date/src/date.rs Resolved
sylvestre
sylvestre reviewed Sep 22, 2026
View reviewed changes
Comment thread src/uu/date/src/date.rs Resolved
sylvestre
sylvestre reviewed Sep 22, 2026
View reviewed changes
Comment thread src/uu/date/src/date.rs Resolved
sylvestre
sylvestre reviewed Sep 22, 2026
View reviewed changes
Comment thread src/uu/date/src/date.rs Resolved
sylvestre
sylvestre reviewed Sep 22, 2026
View reviewed changes
Comment thread src/uu/date/src/date.rs Resolved
Copilot AI review requested due to automatic review settings September 22, 2026 12:42
Copilot AI reviewed Sep 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MuntasirSZN MuntasirSZN changed the title date: support european dates and out-of-range years date: support european dates Sep 22, 2026
@MuntasirSZN

MuntasirSZN commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre another review?

@MuntasirSZN
date: support european DAY.MONTH[.YEAR] dates
0931b4b 
date accepts DAY.MONTH[.YEAR] dates (yearless forms use the current
year). uutils rejected them, failing parts of tests/date/date.pl.

Rewrite european dates to ISO before parsing. Adds unit and integration
tests.

Signed-off-by: MuntasirSZN <muntasir.joypurhat@gmail.com>
@MuntasirSZN
Merge remote-tracking branch 'upstream/main' into date-pl
d26a022
Copilot AI lite review requested due to automatic review settings October 4, 2026 08:26
Copilot AI reviewed Oct 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Extended years fail with explicit formats, and the GNU test-path reference and wording nits remain.

Review effort: Lite
Findings: 2 Medium severity

Open (2)

Comment thread src/uu/date/src/date.rs Resolved
Comment thread tests/by-util/test_date.rs Resolved
@MuntasirSZN

MuntasirSZN commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre a review pls.... (sorry for ping)

Copilot AI lite review requested due to automatic review settings October 11, 2026 15:33
Copilot AI reviewed Oct 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Unresolved issues remain with extended-year formatting, yearless syntax, allocation behavior, and test stability.

0 open findings

2 resolved since last review

🧠 Review effort: Lite

@MuntasirSZN

MuntasirSZN commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Looks like done in another pr

@MuntasirSZN
MuntasirSZN deleted the date-pl branch October 12, 2026 12:16
@xtqqczze xtqqczze mentioned this pull request Oct 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MuntasirSZN @collinfunk @xtqqczze @sylvestre